session_start(); problem

[ExtremeSM]

<?php
session_start();
$lang = $_SESSION["lang"];
if (!$lang) {$lang = $_GET['lang'];}
if ($lang == "ru") {
require("./data/languages/ru.php");
$_SESSION["lang"] = "ru";
}else{
require("./data/languages/en.php");
$_SESSION["lang"] = "en";
}
?>

joxovurt jan ogneq eli, esor inch vor uxexs anjatvaca chem jogum vonc karelia dzel?
uzum em vor skzbic nayi lang ete ka session-i mech stana "ru"-a te "en", ete chka session-i mech get methodov vekali arjeq@ lang-i u gri session-i mej vor myus ejerum mna et en-@ kam ru-n... hima problems nranuma, vor mi angam inq@ mtav get metodov vekalec asenq ru arjeq@, grec sessioni mej, baic heto vor grum em ?lang=en arden chi poxum, mnuma hin session@ =\ vonc karelia dzel?

[Intel]

AFAIK, there's no ordinary way to do that, but there are few workarounds available.

Ask Google about: "Browse Button CSS".

Good luck and productive research.

[ExtremeSM]

хмм... ок сенкс, даже и не подумал чето прогуглить...

П.С.
А что значит АФАИК? О.о

[Mesrop]

Originally Posted by ExtremeSM

хмм... ок сенкс, даже и не подумал чето прогуглить...

П.С.
А что значит АФАИК? О.о

AFAIK - As Far As I Know - насколько мне известно

...

[TasteMyLipstick]

Originally Posted by Silver

Here's an (IMHO) better way of writing the same thing:

And there still are security issues I guess.

If you mean script injection, I prevented it in the following line "...&& in_array($_GET['lang'], $a_languages)" for both $_SESSION and $_GET arrays.

[Intel]

As I've mentioned previously, there's no need to check session vars(because like the database records, session variables and their values must be formed by the script, unlike variables coming from request), except that your code is almost unreadable, and less flexible.

[Silver]

Intel, my code is almost unreadable?!
Dude!!!

[Intel]

No, I meant her code, not yours ;-)

[TasteMyLipstick]

Originally Posted by Intel

As I've mentioned previously, there's no need to check session vars(because like the database records, session variables and their values must be formed by the script, unlike variables coming from request), except that your code is almost unreadable, and less flexible.

What is less flexible about my code? I'd say it's much more flexible than yours, where you used switch case operators for checking the value of every single language. I think it's not so smart to do so.

[Silver]

TasteMyLipstick, switch IMHO is better than if -> elseif -> elseif -> elseif -> else.

[Silver]

Any code is 100% flexible if you can edit it

[Intel]

Originally Posted by TasteMyLipstick

What is less flexible about my code?

Theoretically, for example you can't control, if the $_GET['lang'] is defined, or not. You may only surmise, starting from isset($_GET['lang']) conjunct with in_array($_GET['lang'], $a_languages).

Originally Posted by TasteMyLipstick

I'd say it's much more flexible than yours, where you used switch case operators for checking the value of every single language. I think it's not so smart to do so.

Well, it's not a big deal, I think. Assuming that:
First of all, the count of languages is finite, and in handsome majority of cases not greater than 2 or 3. So probably our switch structure will not grow up so much.
Secoundly, you may perform custom actions different for each language.

In addition:
Your code contains useless assignings, checks, script termination, also it outputs HTML code(which, I suppose, is very rough for back-end layer) ...